[PWGHF] Added safety checks before using ccdb efficiency objects#15653
Merged
apalasciano merged 2 commits intoAliceO2Group:masterfrom Apr 5, 2026
Merged
Conversation
deependra170598
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
apalasciano
approved these changes
Apr 5, 2026
Collaborator
|
@deependra170598 Please fix the documentation in your next PR. |
vkucera
reviewed
Apr 23, 2026
| efficiencyWeightTracks = vecHistEfficiencyTracks[0]->GetBinContent(1); | ||
| } else { | ||
| efficiencyWeightTracks = vecHistEfficiencyTracks[0]->GetBinContent(vecHistEfficiencyTracks[0]->GetXaxis()->FindBin(ptTrack)); | ||
| if (!efficiencyWeightTracks) { |
Collaborator
There was a problem hiding this comment.
This is wrong. You convert float to bool and compare it to false. For that to happen, the float would have to be exactly 0 which almost never happens if the value is a result of a calculation. Furthermore, the syntax signals the intention of using a bool value which is not the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @singhra1994, @apalasciano and @gluparel,
Could you please review this PR?
In this PR, I tried to add safety checks before using ccdb efficiency object so that NAN dose not propagate to the THnSparse.
Let me know you any suggestion or improvement needed, Thanks.